[WebKit-devel] [Bug 232736] Flash mimetype association is ignored

[Dawit Alemayehu]

https://bugs.kde.org/show_bug.cgi?id=232736





--- Comment #3 from Dawit Alemayehu <adawit kde org>  2010-03-31 16:57:00 ---
On Wednesday 31 March 2010 03:06:59 Dawit Alemayehu wrote:
> https://bugs.kde.org/show_bug.cgi?id=232736
> 
> 
> Dawit Alemayehu <adawit at kde.org> changed:
> 
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
> - CC|                            |adawit at kde.org
>           Component|general                     |kdewebkit
>             Product|kwebkitpart                 |kdelibs
> 
> 
> 
> 
> --- Comment #1 from Dawit Alemayehu <adawit kde org>  2010-03-31 09:06:57
> --- (In reply to comment #0)
> BTW, since you seem to have compiled KDE from source, you can easily change
> kdewebkit to use KDE's preferred viewer for flash content by simply
> commenting out the 2 lines below
> 
> if (!excludedMimeType(mimeType))
>     part = KMimeTypeTrader::createPartInstanceFromQuery<...>(...);
> 
> from "kdelibs/kdewebkit/kwebpluginfactory.cpp".

Oops, this is wrong. You should only comment out the if statement! 
Alternatively, you can simply change the excludedMimeType function to return 
false as follows:

static bool excludedMimeType(const QString &type)
{
# if 1
    return false;
#else
    // Let QtWebKit handle flash and java applets...
    return (type == QL1S("application/x-shockwave-flash") ||
            type == QL1S("application/futuresplash") ||
            type.startsWith(QL1S("application/x-java")));
#endif
}

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.