[WebKit-devel] QIcon::fromTheme issues

[Dawit A.]

The QIcon::fromTheme changes/patch actually belongs upstream in QtWebKit. It 
was my mistake to have added it to kdewebkit. Anyhow, attached is a patch that 
reverts those changes back until such time that upstream starts using 
QIcon::fromTheme. When that happens, we can remove that piece of code from 
that class. Please test the patch and let me know if it works so I can commit 
it. I cannot test anything in KDE 4.4...

Thanks.

On Wednesday 20 January 2010 19:47:36 Andrea Diamantini wrote:
> Hi all,
> 
> I noticed in rekonq some icons missing from the menu actions and reading
>  code I saw these are the KWebPage actions.
> In KWebPage ctor the "page actions" are setted with icons and shortcuts,
>  but while shortcuts appear in rekonq contextual menu (and I didn't set
>  them), icons are missing.
> 
> So the question is: why using QIcon::fromTheme instead of KIcon?
> 
> Regards,
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kwebpage_trunk.patch
Type: text/x-patch
Size: 3790 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20100120/09509de1/attachment.patch