[WebKit-devel] Protected Q_SLOTS in KWebPage

[Urs Wolfer]

On Monday 12 October 2009 05:03:01 Michael Howell wrote:
> On Sunday 11 October 2009 05:22:30 you wrote:
> > Michael, do you think it makes sense to have these virtual slots there?
> > Or should the moved to the d-ptr and be declared with Q_PRIVATE_SLOT? If
> > they stay there, I'm not sure about the name. Is it common to call them
> > "slotX"? Also they should be documented.
> >
> > Bye
> > urs
> 
> slotUnsupportedContent is KDE-integration related. It uses KDE's dialogs
> instead of the default Qt ones. It can't be private, because WebPage
>  overloads it to use the KPart one instead. The only thing we can do is
>  rename it.

I'm not sure, how does Qt name such protected slots? Is there a convention?

> I'm not sure why the downloadRequest ones are protected. They should
>  probably be private. Actually, it seems some information has lost sync.
> slotUnsupportedContent in KWebPage, and handleUnsupportedContent in
>  WebPage?

No idea here.. What do you suggest? Make them privat? Any idea in what commit 
it got messed up?

Bye
urs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20091012/d1c3bc97/attachment.sig