[WebKit-devel] AccessManager Integration

[Andrea Diamantini]

On Wednesday 25 November 2009 18:27:05 Dawit A. wrote:
> On Wednesday 25 November 2009 05:39:14 Andrea Diamantini wrote:
> > I'm sorry my comments and reviews usually arrive "out-of-time", but I
> >  really have poor free time in this period..
> 
> Yes, you are very late because all of this stuff was in kdereview for a
>  couple of weeks. ;-) However, it is better to fix this stuff now before it
>  is released because we have to deal with BC after it is released. We just
>  need to make these changes before the hard freeze cutoff today...

We'll ask for an exception :)

[...]
> Well you have very valid points and I agree the cookiejar integration code
>  as well as the meta data access functions should be moved into
>  KIO::AccessManager proper. That was there is no need for the private
>  re-implementation class. And I can remove the the
>  KWebPage::authorizedRequest virtual member function in KWePage because
>  people can simply re-implement KIO::AccessManager to do their own
>  filtering/custom protocol handling as they wish.
> 
> Anyhow, here is a patch to accomplish the above. If someone can test
>  whether it compiles vs trunk, then it can be committed and the stuff
>  removed from kdelibs/kdewebkit...

It doesn't work here. I tried fixing stuffs and here are results. I did some 
trivial fixes and 1 important change in AccessManager::createRequest, merging 
code from the two functions.
Hope can help. Works here

Regards,

-- 
Andrea Diamantini, adjam
GPG Fingerprint: 57DE 8E32 7D1A 0E16 AA52 59D8 84F9 3ECD DBF9 730F

rekonq project
WEB: http://rekonq.sourceforge.net
IRC: rekonq at freenode

-------------- next part --------------
A non-text attachment was scrubbed...
Name: accessmanager2.patch
Type: text/x-patch
Size: 7914 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20091126/b5ffb773/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdewebkit2.patch
Type: text/x-patch
Size: 5086 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20091126/b5ffb773/attachment-0001.patch