[WebKit-devel] Better library/header name for the webkit kpart...

[Dawit A.]

On Sunday 15 November 2009 12:42:05 Urs Wolfer wrote:
> On Sunday 15 November 2009 18:34:02 Dawit A. wrote:
> > On Sunday 15 November 2009 09:44:29 Urs Wolfer wrote:
> > > Nope, this point do not look sane to me. Since it's not something of
> > >  kdelibs, I don't think we should put it into the global include dir.
> > > IMHO ${INCLUDE_INSTALL_DIR}/kwebkitpart would be okay.
> >
> > Well if we follow your logic, then should not kdewebkit install its
> > headers in the global directory since it is now in kdelibs ?
> 
> It does. kdewebkit headers are in the KDE global include dir.

ahhh I see... I should have checked trunk version first instead of going by 
what is in playground! I am not on trunk yet... ;) I will sync the playground 
version to do the same thing for now.

> >  My only issue here
> >  again is that we have two separate include folders for something that is
> >  essentially the same thing. Either we put everything in one folder or
> >  follow what other modules such as khtml do, no ? In other words, if we
> > put the part in kwebkitpart, then whomever uses it in the future will
> > have to include it as
> >
> > #include <KDE/KWebKitPart/KWebKitPart> or
> > #include <kwebkitpart/kwebkitpart.h>
> >
> > Personally I would like to see both kdewebkit and the webkitpart install
> >  their header files to the same location so that all header files
> >  associated with them are in the same location ; so the above becomes:
> >
> > #include <KDE/KWebKit/KWebKitPart>
> > #include <kwebkit/kwebkitpart.h>
> >
> > Additionally creating a spearate folder for a single include file seems
> > an overkill to me...
> 
> Okay, this is probably true. Just think about it: will there be more files
> later? If not, I see no issue with installing it into the global dir.

Well at this point I do not see what additional header files we would want to 
install from there...