[WebKit-devel] Better library/header name for the webkit kpart...

[Urs Wolfer]

On Sunday 15 November 2009 11:17:27 Andrea Diamantini wrote:
> On Sunday 15 November 2009 05:24:10 Dawit A. wrote:
> > The current naming scheme for the webkit kpart is utterly confusing. The
> > library is named "webkitkde". The KDE wrapper that was recently moved to
> > kdelibs produces a library called "kdewebkit"! As such I am proposing the
> > following changes:
> >
> > #1. Rename webkitkde to kwebkit.
> > #2. Rename webkitpart to kwebkitpart.
> > #3. Rename all classes, files named webkitpart.* to kwebkitpart.*
> > #4. Install kwebkitpart.h under ${INCLUDE_INSTALL_DIR} not
> > ${INCLUDE_INSTALL_DIR}/webkitkde
> > #5. Same thing as #4 for the C++ style header file install.
> >
> > All of these changes would make the webkit kpart follow defacto KDE
> > naming conventions and be available in the very same locations as most
> > other kparts, e.g. khtml. If there are objections to doing this, then we
> > at least need to change the name of the part library (NOTE: I am aware
> > the kpart plugin library is named "webkitpart").
> 
> I'm ok with these changes. Just I don't understand why we didn't follow the
> same rules naming the kdewebkit library now in kdelibs (calling it
>  kwebkit).

It's just the lib which is names kdewebkit (just like the other kdelibs libs). 
The classes itself are named KWeb*...

So I don't think it does really matter, but I prefer KWebKitPart.

Bye
urs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20091115/d07dbdf7/attachment.sig