[WebKit-devel] [Patch] Add the "Frame" menu like Konqueror

[Alain Laporte]

> De: Dawit A. <adawit at kde.org>
> Objet: Re: [WebKit-devel] [Patch] Add the "Frame" menu like Konqueror
> À: webkit-devel at kde.org
> Date: Lundi 2 Novembre 2009, 21h10
> On Sunday 01 November 2009 18:01:06
> Alain Laporte wrote:
> > > De: Urs Wolfer <uwolfer at kde.org>
> > > On Wednesday 28 October 2009 03:45:31
> > >
> > > Alain Laporte wrote:
> > > > Hello,
> > > >
> > > > I have patched WebKitKDE for to add the
> Frame menu
> > >
> > > like in Konqueror (the
> > >
> > > >  code for add the entries is an
> adaptation of
> > >
> > > this :
> > > > 
> > > > http://websvn.kde.org/trunk/KDE/kdelibs/khtml/khtml_ext.cpp?view=markup
> > >
> > > ).
> > >
> > > > The entry to show the informations on the
> page isn't
> > >
> > > active because the
> > >
> > > >  window doesn't exists (i think...).
> > > >
> > > > For reloading entry, i'm not sure of the
> code. I do a
> > >
> > > load() with the
> > >
> > > >  frame's URL, but the cache is maybe
> used.
> > >
> > > Hi Alain
> > >
> > > The code looks good to me, though I have not
> tested
> > > anything... Please attach
> > > the patch as a file; otherwise it's hard to apply
> it
> > > becuase of whitespace
> > > changes.
> > >
> > > Bye
> > > urs
> > 
> > Hi,
> > 
> > Here is the patch attached.
> 
> No objections to the patch itself, but everyone please hold
> off applying this 
> patch until I have committed my rather large changes that
> fixes history 
> navigation once and for all in the webkitpart...
> 
> Thanks.
Here is the patch based on the lastest revision. I have tested the new menu again and it work fine.

It's ready to commit by anyone! ;-)

My future work will be on the PageInfo dialog (the entry commented in the menu), like this : 
http://websvn.kde.org/trunk/KDE/kdelibs/khtml/htmlpageinfo.ui?view=markup

Alain Laporte.


      
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_frame_menu.diff
Type: application/octet-stream
Size: 6610 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/webkit-devel/attachments/20091102/eb0da924/attachment.dll