[WebKit-devel] [Patch] Add the "Frame" menu like Konqueror

Dawit A. adawit at kde.org
Mon Nov 2 21:10:07 CET 2009


On Sunday 01 November 2009 18:01:06 Alain Laporte wrote:
> > De: Urs Wolfer <uwolfer at kde.org>
> > On Wednesday 28 October 2009 03:45:31
> >
> > Alain Laporte wrote:
> > > Hello,
> > >
> > > I have patched WebKitKDE for to add the Frame menu
> >
> > like in Konqueror (the
> >
> > >  code for add the entries is an adaptation of
> >
> > this :
> > > 
> > > http://websvn.kde.org/trunk/KDE/kdelibs/khtml/khtml_ext.cpp?view=markup
> >
> > ).
> >
> > > The entry to show the informations on the page isn't
> >
> > active because the
> >
> > >  window doesn't exists (i think...).
> > >
> > > For reloading entry, i'm not sure of the code. I do a
> >
> > load() with the
> >
> > >  frame's URL, but the cache is maybe used.
> >
> > Hi Alain
> >
> > The code looks good to me, though I have not tested
> > anything... Please attach
> > the patch as a file; otherwise it's hard to apply it
> > becuase of whitespace
> > changes.
> >
> > Bye
> > urs
> 
> Hi,
> 
> Here is the patch attached.

No objections to the patch itself, but everyone please hold off applying this 
patch until I have committed my rather large changes that fixes history 
navigation once and for all in the webkitpart...

Thanks.


More information about the WebKit-devel mailing list