[WebKit-devel] [Bug 191361] New: WebKit part crashes when createNewWindow signal is not connected

[Paweł Prażak]

https://bugs.kde.org/show_bug.cgi?id=191361

           Summary: WebKit part crashes when createNewWindow signal is not
                    connected
           Product: webkitkde
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: crash
          Priority: NOR
         Component: WebKit KPart
        AssignedTo: webkit-devel at kde.org
        ReportedBy: kojot350 at gmail.com


Version:            (using Devel)
Compiler:          gcc (SUSE Linux) 4.3.2 [gcc-4_3-branch revision 141291] 
OS:                Linux
Installed from:    Compiled sources

When createNewWindow signal is not connected WebKit part crashes (in debugging
code).

I know that browser should connect this signal to work properly, but part
should not crash as well.

this is a very simple patch

Index: part/webpage.cpp
===================================================================
--- part/webpage.cpp    (revision 961330)
+++ part/webpage.cpp    (working copy)
@@ -80,7 +80,10 @@
                                                      KParts::WindowArgs(),
&part);
     WebKitPart *webKitPart = qobject_cast<WebKitPart*>(part);
     if (!webKitPart) {
-        kDebug() << "got NOT a WebKitPart but a" <<
part->metaObject()->className();
+        if (part)
+            kDebug() << "got NOT a WebKitPart but a" <<
part->metaObject()->className();
+        else
+            kDebug() << "part is null";
         return 0;
     }
     return webKitPart->view()->page();

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.