[WebKit-devel] [PATCH] WebKitPart and KdeNetwork source directories

[Urs Wolfer]

On Friday 05 September 2008 05:02:25 Michael Howell wrote:
> This patch moved WebKitPart and KdeNetwork into their own separate source
> directories.

Patch looks basically good to me, though it's hard to review such a large 
patch which moves all files around.. (and I think some files are not included 
in the patch).

I'm okay with the move, but please really use "svn cp" for everything.

Also, take in mind, that there are already some parts of apps in KDE 
mainmodules, which already depend optionally on KDE WebKit... (some Konqueror 
plugins IIRC). Because of this unfortunate situation, you have to take care 
that you do not break these modules. (either port them to new API if you 
change / rename stuff and do some compile time checks, or add compatibilty 
stuff in our code (which is not very nice in such "new" code...).

Bye
urs