[Breeze] [Bug 486866] New: Rebuild of breeze-icons fails

[Jonathan L Hanmann]

https://bugs.kde.org/show_bug.cgi?id=486866

            Bug ID: 486866
           Summary: Rebuild of breeze-icons fails
    Classification: Plasma
           Product: Breeze
           Version: master
          Platform: Ubuntu
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: Icons
          Assignee: visual-design at kde.org
          Reporter: jhanmann at ca.rr.com
                CC: kainz.a at gmail.com, m at nueljl.in
  Target Milestone: ---

A rebuild fails with apps path already existing. This may require
make-install-prefix set to sudo although I haven't gone back and verified this
as a prerequisite. The following patch (which may be an improper solution)
works around the failure at least:

diff --git a/create-app-symlinks.py b/create-app-symlinks.py
index a31777bf..42c5f37b 100644
--- a/create-app-symlinks.py
+++ b/create-app-symlinks.py
@@ -148,7 +148,8 @@ created_symlinks = dict()

 for dirpath, _, filenames in os.walk(os.path.join(SRCDIR, "apps")):
     outpath = os.path.join(BINDIR + dirpath[len(SRCDIR):])
-    os.makedirs(outpath)
+    if os.path.exists(outpath) == False:
+        os.makedirs(outpath)
     for file in filenames:
         if file[-4:] == ".svg":
             base = file[:-4]
@@ -156,7 +157,8 @@ for dirpath, _, filenames in os.walk(os.path.join(SRCDIR,
"apps")):
                 created_symlinks[base] = dict()
             if base in aliases:
                 for alias in aliases[base]:
-                    os.symlink(file, os.path.join(outpath, alias + ".svg"))
+                    if os.path.lexists(os.path.join(outpath, alias + ".svg"))
== False:
+                        os.symlink(file, os.path.join(outpath, alias +
".svg"))
                     if alias not in created_symlinks[base].keys():
                         created_symlinks[base][alias] = []
                    
created_symlinks[base][alias].append(int(outpath.split('/')[-1]))

-- 
You are receiving this mail because:
You are the assignee for the bug.