[Breeze] [Bug 448169] Contrast for Breeze Dark's Places icons with light foreground clashes

[Luke Horwell]

https://bugs.kde.org/show_bug.cgi?id=448169

--- Comment #4 from Luke Horwell <code at horwell.me> ---
My latest crude workaround is throwing together a mix-and-match of 5.87 and
6.0.x icon theme. Taking the latest icon developments from 6.0.x but the static
icons from 5.87 with some search & replace hacks. This works better for the
Breeze Dark theme.

https://github.com/lah7/breeze-dark-icons-static-mix

It also "fixed" BUG 482648 too, where symbolic icons were not working below ~32
pixels, but it's not the solution of course.

---

While investigating, some of the earlier comments are outdated.

- The previously suggested CSS class removal no longer works after 6.3.0, for
some reason.
- KIconThemes is doing the recolouring  [src/kiconcolors.cpp]
- CSS "ColorScheme-Text" maps to "highlightedText"

I guess, that's the problem - it currently assumes text colour is OK if the
accent colour is used as a background. To reproduce, use "Breeze Dark" window
theme with a white accent colour, you'd expect a darker inner icon for places
folders. Likewise, try a black accent colour under "Breeze Light". In both
cases, the places icons are indistinguishable.

In terms of fixing this, I'd suggest:

- A new CSS variable applies a colour tint based on the accent colour. This can
be used for the 'inner icon' inside places icons. The hex code can be checked
to determine this.
    E.g. For a bright accent colour, go darker. If it's a dark accent colour,
go lighter.  For Breeze' default blue, it would go darker (#366681).

-- 
You are receiving this mail because:
You are the assignee for the bug.