[plasmashell] [Bug 478022] When clicking log out, restart, or power off, confirmation screen has all options, not just the one I chose earlier

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=478022

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |6.1
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-workspace/-/commi
                   |                            |t/aeafc00970259e5f1594f284e
                   |                            |2bef30a50975688
         Resolution|---                         |FIXED

--- Comment #5 from Nate Graham <nate at kde.org> ---
Git commit aeafc00970259e5f1594f284e2bef30a50975688 by Nate Graham.
Committed on 29/01/2024 at 16:56.
Pushed by ngraham into branch 'master'.

Simplify logout greeter UI when invoked with a specific option

Right now the logout greeter always shows all available power/session
actions (except for Lock, for some reason) regardless of how it was
invoked, plus a cancel button and an OK button.

As a result, though it is essentially a confirmation screen, it offers the
user options to change their mind after the fact and perform a different
action from the one they started with, including those like Sleep and
Hibernate that don't exit the session at all.

This isn't ideal as it presents a somewhat strange and cluttered UI to
the user, full of options that are unlikely to be used.

To improve the situation, when the dialog is invoked with a specific
option, now we only show that option plus a cancel button.

When the dialog is *not* invoked with any option, (e.g. from the
off-by-default "Leave" item in the desktop context menu, or the
Ctrl+Alt+Delete global shortcut), all options are still shown, with
"Shut Down" pre-selected--as was the prior intention, but it wasn't
working. This required some re-plumbing as the dialog wasn't previously
designed to support this kind of dual-mode operation. The greeter's
windowed test mode is also updated to always show all available options.
FIXED-IN: 6.1

M  +7    -7    containmentactions/contextmenu/menu.cpp
M  +1    -0    ksmserver/org.kde.LogoutPrompt.xml
M  +14   -0    libkworkspace/sessionmanagement.cpp
M  +6    -0    libkworkspace/sessionmanagement.h
M  +10   -1    logout-greeter/greeter.cpp
M  +1    -0    logout-greeter/greeter.h
M  +73   -81   lookandfeel/org.kde.breeze/contents/logout/Logout.qml
M  +12   -2    startkde/session-shortcuts/main.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/aeafc00970259e5f1594f284e2bef30a50975688

-- 
You are receiving this mail because:
You are on the CC list for the bug.