[Breeze] [Bug 460449] Breeze icon theme doesn't fall back to Adwaita, causing missing icons in many GNOME apps

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=460449

poudinkpopinski at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |poudinkpopinski at gmail.com

--- Comment #3 from poudinkpopinski at gmail.com ---
> Is the necessary change here as simple as adding Adwaita to the `Inherits=` key in the `index.theme` files
> for the Breeze and Breeze Dark icon sets in https://invent.kde.org/frameworks/breeze-icons/ ? If so, would
> there be any issues if the change is made and a user happens to not have the Adwaita theme? (other than
> Adwaita only icons being broken like it is now)
Inheriting a missing icon theme causes no issues. Since GTK3 and GTK4 have the
Adwaita icon theme as a dependency, simply inheriting Adwaita should be enough
to fix all cases of broken icons in GTK apps (caused by this particular issue).

> That said, I just tried running Bottles through Flatpak on my Fedora Kinoite install and I can't find any
> missing icons (at least not the ones shown in the linked issues below), so I guess the Bottles devs
> have worked around the issue already, and at the moment I don't know of any other app affected (I gave
> GNOME Web a quick try and I didn't see any clearly broken icons for example).
I don't see any missing icons in Bottles either. A lot of icons do successfully
fall back to Adwaita despite the missing inherit, it's only a few that end up
breaking and from my experience it only happens with GTK4 apps (maybe
libadwaita? non-libadwaita GTK4 apps are pretty rare). Also, Breeze already
covers most of Adwaita's common icons, so it's difficult to find broken icons.
There are still a few, though. The icon for broken symlinks in Nautilus is
broken with Breeze. GNOME Control Center also has a bunch of broken icons. You
probably shouldn't be running Control Center in KDE, but it's still a problem
for those wishing to use Breeze icons on GNOME.

-- 
You are receiving this mail because:
You are the assignee for the bug.