[plasmashell] [Bug 465920] When I lock the screen and then press ESC key, the login controls unhide immediately before the screen is turned off

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=465920

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/plasma-workspace/commit/ |ma/plasma-workspace/commit/
                   |8879fefe8f3f4d18c92b8216538 |e1fa127278d3dc470141fe1cbef
                   |d24817adab42e               |df2ee0e393872

--- Comment #2 from Nate Graham <nate at kde.org> ---
Git commit e1fa127278d3dc470141fe1cbefdf2ee0e393872 by Nate Graham, on behalf
of Bartosz Taudul.
Committed on 21/02/2023 at 18:00.
Pushed by ngraham into branch 'Plasma/5.27'.

Lock screen: Prevent Escape key from displaying UI if it's currently hidden

Merge request https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/99
implemented turning off the screen when the Escape key is pressed on the lock
screen. However, the lock screen UI logic was not updated to take this into
account.

There are two behaviors to consider here. The first is such that pressing the
Escape key on the password prompt clears the entry and hides the UI. This is
expected and works well in conjunction with the screen going off. When the
user returns to the computer after a while and tries to log in again, they
would not expect to see a partially typed password. Or, even worse, the user
might enter the password and then press the Escape key. If the previous entry
were left as entered, unbeknownst to the user, an adversary could gain access
to the user's account.

The second behavior is when the password entry UI is not displayed. In this
case, the UI logic reacted by displaying the password entry prompt. While
this behavior may have been fine before, with the change to turn off the
screen, this looks like some sort of bug.

This commit disables Escape key handling when the password entry UI is not
visible.
FIXED-IN: 5.27.2


(cherry picked from commit 8879fefe8f3f4d18c92b8216538d24817adab42e)

M  +7    -5    lookandfeel/org.kde.breeze/contents/lockscreen/LockScreenUi.qml

https://invent.kde.org/plasma/plasma-workspace/commit/e1fa127278d3dc470141fe1cbefdf2ee0e393872

-- 
You are receiving this mail because:
You are on the CC list for the bug.