[plasmashell] [Bug 417511] Dark panels have light-colored visual glitches in their rounded corners

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=417511

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|5.26.1                      |5.101
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/fram
                   |ma/plasma-workspace/commit/ |eworks/plasma-framework/com
                   |b68a93efee8a1b1de86f3689c0d |mit/575d0de125cd9b6d60ca5a5
                   |b685f6a74adf9               |1ebc32c9bd0dd05ea

--- Comment #19 from Nate Graham <nate at kde.org> ---
Git commit 575d0de125cd9b6d60ca5a51ebc32c9bd0dd05ea by Nate Graham, on behalf
of Niccolò Venerandi.
Committed on 25/11/2022 at 16:39.
Pushed by ngraham into branch 'master'.

Rework Plasma theme mask corners and outlines

This patch reverts Marco's idea of making the mask of dialogs smaller by 1px
(and https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2276
reverts
my patch doing the same for the panel); instead, this MR reduces the mask by
1px,
but only for the corner elements.

The issue with reducing the whole mask by 1px is that you'll get a dark outline
in
Breeze Dark (both on the panel and the dialogs) *and* you'll be able to see the
wallpaper through the panel/dialog in its outermost pixel.

This patch still isn't perfect. With some combination of colorscheme and
wallpaper,
you might still notice some slight darkening going on in the corners. This
happened
before this MR too, but at least now it happens *only* in the corners. It's
much
less noticeable; especially since most people seem to notice it only for the
panel,
which in most cases does not have any rounded corners (but it does have sides,
so
this MR - which makes the bug only appear in corners - is a great step
forward).
FIXED-IN: 5.101

M  +643  -111  src/desktoptheme/breeze/dialogs/background.svg
M  +622  -120  src/desktoptheme/breeze/solid/dialogs/background.svg
M  +656  -121  src/desktoptheme/breeze/solid/widgets/background.svg
M  +663  -125  src/desktoptheme/breeze/solid/widgets/panel-background.svg
M  +625  -128  src/desktoptheme/breeze/solid/widgets/tooltip.svg
M  +649  -120  src/desktoptheme/breeze/translucent/dialogs/background.svg
M  +687  -125  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
M  +649  -120  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
M  +687  -125  src/desktoptheme/breeze/widgets/panel-background.svg
M  +261  -59   src/desktoptheme/breeze/widgets/plasmoidheading.svg
M  +649  -120  src/desktoptheme/breeze/widgets/tooltip.svg
M  +1    -5    src/plasmaquick/dialog.cpp

https://invent.kde.org/frameworks/plasma-framework/commit/575d0de125cd9b6d60ca5a51ebc32c9bd0dd05ea

-- 
You are receiving this mail because:
You are the assignee for the bug.