[Breeze] [Bug 448169] Contrast for Breeze Dark's Places icons with light foreground clashes

[Luke Horwell]

https://bugs.kde.org/show_bug.cgi?id=448169

--- Comment #1 from Luke Horwell <code at horwell.me> ---
I tried looking into this, but I'm stumped. A git bisect between v5.87.0 and
v5.88.0 reveals that 1b92cfc450f6ab6b72ed9ef69c052e4624e5a040 ("Remove exact
duplicate icons from dark theme") was the first commit to introduce the issue,
but it seems like something else is involved.

If the change was intended to deduplicate icons from the source and so dark
coloured themes use lighter monochrome icon colours (like toolbars, menus), it
kind of makes sense - this bug would be about the wrong monochrome colour being
used/forced inside a folder icon when dark colour scheme like Breeze Dark is
set.

Some questions to help understand the situation:

- Where's the code that changes the behaviour when a dark colour scheme is
selected?
- Why would icon previews in the icon picker (32px) show the original icons,
but Dolphin renders modified icons?
- Why would places icons (32, 48, 64, 96) in
/usr/share/icons/{breeze,breeze-dark} be exactly the same?
- Can this be disabled (at build, env variable, hidden config file)? 

Possible guesstimate solutions:

- Skip processing places icons over 32px?
- Add a checkbox in System Settings' Icons or Colours tab to set icon
foreground to dark/light?

-- 
You are receiving this mail because:
You are the assignee for the bug.