[Breeze] [Bug 409546] collapse-all icons don’t respect color schemes

Nate Graham bugzilla_noreply at kde.org
Sun Jul 7 13:26:17 BST 2019


https://bugs.kde.org/show_bug.cgi?id=409546

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/bre
                   |                            |eze-icons/8ec6b1ba567029067
                   |                            |e458525048477a489b042c3

--- Comment #1 from Nate Graham <nate at kde.org> ---
Git commit 8ec6b1ba567029067e458525048477a489b042c3 by Nate Graham, on behalf
of Natsumi Higa.
Committed on 07/07/2019 at 12:26.
Pushed by ngraham into branch 'master'.

Add id="current-color-scheme" to collapse-all icons

Summary:
`collapse-all` icons have no `id="current-color-scheme"` attribute in the
`<style>` element, so they do not respect the foreground color and these icons
are hardly visible in dark color themes.

Special thanks: David Hurka, who reported the bug and suggested the change

Usage in Okular, Before:
{F6848602}
After:
{F6980718}

Reviewers: #vdg, davidhurka, ndavis

Reviewed By: #vdg, davidhurka, ndavis

Subscribers: ndavis, davidhurka, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22297

M  +9    -2    icons-dark/actions/16/collapse-all.svg
M  +9    -2    icons-dark/actions/22/collapse-all.svg
M  +9    -2    icons-dark/actions/24/collapse-all.svg
M  +9    -2    icons-dark/actions/32/collapse-all.svg
M  +9    -2    icons/actions/16/collapse-all.svg
M  +9    -2    icons/actions/22/collapse-all.svg
M  +9    -2    icons/actions/24/collapse-all.svg
M  +9    -2    icons/actions/32/collapse-all.svg

https://commits.kde.org/breeze-icons/8ec6b1ba567029067e458525048477a489b042c3

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Visual-design mailing list