[Breeze] [Bug 407662] breeze dark: "Advanced permissions" window has almost invisible icons

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=407662

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |/100fb70e6162d15fdc15fd2c76
                   |                            |937435113a129e
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.62

--- Comment #4 from Nate Graham <nate at kde.org> ---
Git commit 100fb70e6162d15fdc15fd2c76937435113a129e by Nate Graham.
Committed on 04/08/2019 at 03:08.
Pushed by ngraham into branch 'master'.

[Permissions editor] Port icons to use QIcon::fromTheme()

Summary:
The permissions editor was using custom low-resolution pixmaps, which did not
respect
the icon theme or color scheme and frequently just looked bad, including with a
high
DPI screen or when using a dark theme.

This patch ports it to use icons from the active icon theme using
`QIcon::fromTheme()`.
FIXED-IN: 5.62

Test Plan:
All functionality still works.

Looks better, especially with Breeze icons, a dark color scheme, and a high DPI
scale
factor: {F7144856}

Reviewers: #frameworks, cfeck, davidedmundson

Reviewed By: davidedmundson

Subscribers: davidedmundson, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22905

D  +-    --    src/widgets/images/group-grey.png
D  +-    --    src/widgets/images/group.png
D  +-    --    src/widgets/images/mask.png
D  +-    --    src/widgets/images/others-grey.png
D  +-    --    src/widgets/images/others.png
D  +-    --    src/widgets/images/user-grey.png
D  +-    --    src/widgets/images/user.png
D  +-    --    src/widgets/images/yes.png
D  +-    --    src/widgets/images/yespartial.png
M  +29   -47   src/widgets/kacleditwidget.cpp
M  +1    -13   src/widgets/kacleditwidget_p.h

https://commits.kde.org/kio/100fb70e6162d15fdc15fd2c76937435113a129e

-- 
You are receiving this mail because:
You are the assignee for the bug.