[filelight] [Bug 501110] Filelight does wrongly calculate because of hard links

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=501110

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sitter at kde.org
     Ever confirmed|0                           |1
             Status|REPORTED                    |CONFIRMED

--- Comment #1 from Harald Sitter <sitter at kde.org> ---
The code that is meant to deduplicate hardlinks is not correctly implemented.

Currently it resides on the PosixWalker as a std::set, skipping nodes that are
already in the set. The walkers are run in any number of threads though, so
that set is never complete. Needs some thinking about where to best track this.
A global cache across all walkers would work, but needs mutexing so maybe
passing the dev-inode out of the walker is more efficient (we have a global
accumulation lock anyway) but then we kinda break abstraction a bit.

-- 
You are receiving this mail because:
You are the assignee for the bug.