[Koko] [Bug 506465] Double quotes in the path cause images to fail to open in Koko

[Oliver Beard]

https://bugs.kde.org/show_bug.cgi?id=506465

Oliver Beard <olib141 at outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/koko/-/commit/73b35165
                   |                            |3ed1842afd99ce7c7a790d588da
                   |                            |20234
         Resolution|---                         |FIXED

--- Comment #2 from Oliver Beard <olib141 at outlook.com> ---
Git commit 73b351653ed1842afd99ce7c7a790d588da20234 by Oliver Beard.
Committed on 07/08/2025 at 14:10.
Pushed by olib into branch 'master'.

Fix mishandling of URL containing quotes in QUrl–QString dance

Rather than keep converting a path between QUrl and QString, just keep it as a
QUrl and do the right things: we have a QUrl, ImageFolderModel wants a QUrl.
Keep it as a QUrl.

We can instead use QUrl functionality to get the parent directory, rather than
manipulate a string. This fixes an issue where 'Open With'/arguments to a file
where a parent directory has quotes, literally "something", causes an error in
ImageFolderModel.

M  +2    -3    src/dirmodelutils.cpp
M  +1    -1    src/dirmodelutils.h
M  +3    -4    src/qml/Main.qml

https://invent.kde.org/graphics/koko/-/commit/73b351653ed1842afd99ce7c7a790d588da20234

-- 
You are receiving this mail because:
You are the assignee for the bug.