[KRdp] [Bug 488372] Consider suppressing the portal confirmation dialog on connection

Arjen Hiemstra bugzilla_noreply at kde.org
Thu Jun 13 10:42:58 BST 2024


https://bugs.kde.org/show_bug.cgi?id=488372

--- Comment #5 from Arjen Hiemstra <ahiemstra at heimr.nl> ---
Git commit 8cea6fb883bb387c4d1adadad3bfe79b387c1abc by Arjen Hiemstra.
Committed on 12/06/2024 at 11:06.
Pushed by ahiemstra into branch 'master'.

server: Create a single temporary portal session on server startup

We want to ask the user for permission when it's convenient, not when
there's nobody at the machine to confirm the permissions. So create a
portal session at startup to request the permisisons.

Unfortunately we cannot reuse this portal session since it leads to
reconnection issues with the PipeWire stream. While that is probably
solvable it also causes additional problems, most notably that the
"Remote Desktop" SNI will be constantly active. So instead, discard the
session after it was successfully started and create a new session when
a new connection is incoming.

This assumes the user checked "remember" for the portal permission.
Unfortunately there is not a whole lot we can do to force that. In
general the permission model here is rather lacking.

M  +35   -17   server/SessionController.cpp
M  +10   -3    server/SessionController.h
M  +1    -2    server/main.cpp

https://invent.kde.org/plasma/krdp/-/commit/8cea6fb883bb387c4d1adadad3bfe79b387c1abc

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Unassigned-bugs mailing list