[Tokodon] [Bug 497915] Sometimes notifications are the wrong type

[Joshua Goins]

https://bugs.kde.org/show_bug.cgi?id=497915

Joshua Goins <josh at redstrate.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/tokodon/-/commit/4b115b
                   |                            |cf2e366fa494a060e0e929eec1a
                   |                            |5af10e5

--- Comment #1 from Joshua Goins <josh at redstrate.com> ---
Git commit 4b115bcf2e366fa494a060e0e929eec1a5af10e5 by Joshua Goins.
Committed on 26/12/2024 at 20:38.
Pushed by redstrate into branch 'master'.

Fix crash when receiving unknown notifications

There's a Q_UNREACHABLE() in the default case, but this turns out to be
pretty bad. The server can send unknown notifications behind our back or
we don't send it post it as a notification yet.

This fixes a regular crash I've seen when receiving push notifications.
I also added a warning I can grep for in the logs whenever a
notification type is unknown.

M  +4    -2    src/account/notificationhandler.cpp
M  +7    -1    src/timeline/notification.cpp
M  +2    -1    src/timeline/notification.h
M  +5    -0    src/tokodon.notifyrc

https://invent.kde.org/network/tokodon/-/commit/4b115bcf2e366fa494a060e0e929eec1a5af10e5

-- 
You are receiving this mail because:
You are the assignee for the bug.