[frameworks-solid] [Bug 497299] Loop Mounts crash Plasmashell in Solid::StorageAccess::filePath

Nicolas Fella bugzilla_noreply at kde.org
Thu Dec 12 09:08:15 GMT 2024


https://bugs.kde.org/show_bug.cgi?id=497299

Nicolas Fella <nicolas.fella at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
                   |eworks/solid/-/commit/2f882 |eworks/solid/-/commit/8bcf3
                   |5b489ecc69bed67a49abdcb643d |3708d2ee6d3756918df130df50f
                   |1fa42b4a                    |bc08a500

--- Comment #8 from Nicolas Fella <nicolas.fella at gmx.de> ---
Git commit 8bcf33708d2ee6d3756918df130df50fbc08a500 by Nicolas Fella.
Committed on 12/12/2024 at 09:07.
Pushed by nicolasfella into branch 'kf5'.

Add null check for StorageAccess interface in storageAccessFromPath

In slotInterfacesRemoved we do a remove+add cycle

During that cycle the backend object is null, so querying the StorageAccess
interface will return null.

This means that when something calls storageAccessFromPath in reaction to
the removed signal we will get a null StorageAccess.

The overall design is a bit shaky here, but we can handle it more gracefully
by checking the result for null
Related: bug 492578

SENTRY: PLASMA-WORKSPACE-11Q1

SENTRY: KDECONNECT-KDE-BK

SENTRY: DOLPHIN-320

SENTRY: KDED-7M

SENTRY: FALLTHROUGH-62S

SENTRY: KATE-Y3

SENTRY: KDENLIVE-VR

SENTRY: XDG-DESKTOP-PORTAL-KDE-3R

SENTRY: KDEVELOP-93

SENTRY: KRUNNER-GD

SENTRY: PLASMA-WORKSPACE-1986

SENTRY: ELISA-9H
(cherry picked from commit 2f8825b489ecc69bed67a49abdcb643d1fa42b4a)

M  +5    -0    src/solid/devices/frontend/devicemanager.cpp

https://invent.kde.org/frameworks/solid/-/commit/8bcf33708d2ee6d3756918df130df50fbc08a500

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Unassigned-bugs mailing list