[Tokodon] [Bug 492383] Freezes when trying to login

[Joshua Goins]

https://bugs.kde.org/show_bug.cgi?id=492383

Joshua Goins <josh at redstrate.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/tokodon/-/commit/c0f910
                   |                            |a3439e30cb18b375f69ebc61574
                   |                            |290caba
         Resolution|---                         |FIXED

--- Comment #6 from Joshua Goins <josh at redstrate.com> ---
Git commit c0f910a3439e30cb18b375f69ebc61574290caba by Joshua Goins.
Committed on 31/08/2024 at 17:16.
Pushed by redstrate into branch 'master'.

Do not reload accounts when initially setting the application proxy

This is quite the sneaky issue, but I think it goes like this:

1. NetworkController is initialized by the QML engine and it's
constructor is called
2. setApplicationProxy is called within said constructor
3. AccountManager's reloadAccounts is called, which in turn emits
accountsReloaded
4. accountsReloaded can trigger some signal handler in QML, in turn
making the QML engine initialize NetworkController again

Now setApplicationProxy has an optional parameter used by
NetworkController's constructor to prevent this situation from happening
in the first place.

M  +7    -3    src/network/networkcontroller.cpp
M  +2    -1    src/network/networkcontroller.h

https://invent.kde.org/network/tokodon/-/commit/c0f910a3439e30cb18b375f69ebc61574290caba

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.