[kdenetwork-filesharing] [Bug 466786] "make me a group member" button didn't work because the samba user shares group didn't contain the text "samba", but this wasn't mentioned anywhere

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=466786

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |23.04
      Latest Commit|                            |https://invent.kde.org/netw
                   |                            |ork/kdenetwork-filesharing/
                   |                            |commit/64998586b683d1268a26
                   |                            |0ae228eb35c3bdb1e55a
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Nate Graham <nate at kde.org> ---
Git commit 64998586b683d1268a260ae228eb35c3bdb1e55a by Nate Graham.
Committed on 10/03/2023 at 13:49.
Pushed by ngraham into branch 'master'.

Fix incorrect conditions and instructions in group setup

Right now the setup wizard checks for whether the group contains the
text "root", and if it does, it errors out and recommends that you
change the group owner to "usershares." But this isn't valid either; in
authhelper.cpp, it will only accept a group with the word "samba" in it,
plus a few other conditions.

This commit makes the frontend code for the wizard match the backend
conditions, so never recommends doing something invalid, which will then
fail.
FIXED-IN: 23.04

M  +1    -0    samba/filepropertiesplugin/authhelper.cpp
M  +7    -3    samba/filepropertiesplugin/groupmanager.cpp

https://invent.kde.org/network/kdenetwork-filesharing/commit/64998586b683d1268a260ae228eb35c3bdb1e55a

-- 
You are receiving this mail because:
You are the assignee for the bug.