[policykit-kde-agent-1] [Bug 473720] Authentication dialog has a generic icon

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=473720

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drf at kde.org,
                   |                            |jgrulich at redhat.com,
                   |                            |jreznik at redhat.com,
                   |                            |nate at kde.org
            Version|unspecified                 |master
             Status|REPORTED                    |CONFIRMED
            Product|kde                         |policykit-kde-agent-1
     Ever confirmed|0                           |1
          Component|general                     |general

--- Comment #1 from Nate Graham <nate at kde.org> ---
Can confirm. I see the problem: the new auth dialog respects the icon set by
the authentication action itself. However it looks like most of our actions use
the `kauth-example` icon for this, which doesn't exist, so the Kirigami.Icon
that tries to render it fails and falls back to the generic document icon.

We would fix this in all of our kauth actions by setting appropriate icons.
However in addition to the fact that this would be a lot of work, it would
probably produce a subpar result since every auth dialog could have a different
random icon. Really the only icon that actually makes sense here is a generic
lock icon, and the simplest way to enforce this is to just hardcode the dialog
to always show it. This appears to be what the old dialog was doing with the
dialog-password icon. Let's do it again for the new one.

-- 
You are receiving this mail because:
You are the assignee for the bug.