[clazy] [Bug 431789] False positive with -clazy-inefficient-qlist

Sergio Martins bugzilla_noreply at kde.org
Sun Feb 7 13:12:35 GMT 2021


https://bugs.kde.org/show_bug.cgi?id=431789

Sergio Martins <smartins at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INTENTIONAL
             Status|REPORTED                    |RESOLVED

--- Comment #1 from Sergio Martins <smartins at kde.org> ---
Calling values QMap::values() just makes it worse, as it allocates a temporary
container, see README-container-anti-pattern.md.

Ofc, people will always find cases where "but here it's useful for me!", for
that reason, inefficient-qlist is disabled by default, and there's
inefficient-qlist-soft.

Anyway, no point on spending our weekend around this since it's already a
non-issue in Qt 6, where this check doesn't make sense anymore. Any effort
spend here will be wasted in the long run.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Unassigned-bugs mailing list