[knetattach] [Bug 425321] knetattach Help button gives 404 page in browser

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=425321

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-desktop/commit/24
                   |                            |7d9d732d522548bd8c07a309666
                   |                            |9125a28e60d

--- Comment #2 from Nate Graham <nate at kde.org> ---
Git commit 247d9d732d522548bd8c07a3096669125a28e60d by Nate Graham, on behalf
of Rijul Gulati.
Committed on 19/08/2020 at 03:10.
Pushed by ngraham into branch 'master'.

Fix clicking Help button gives 404 page in browser

Issue: With khelpcenter unavailable, clicking Help button in knetattach opens
URL: https://docs.kde.org/stable5/en/kde-workspace/knetattach//knetattach
resulting in 404 (Not found) page.

Fix: change help string from `help:/knetattach` to `help:/`.

How it works: at
https://invent.kde.org/frameworks/kguiaddons/-/blob/master/src/util/urlhandler.cpp#L48
- the appname is added by default to docpath. With `help:/knetattach` the
docpath becomes `knetattach&path=/knetattach` which results in URL:
https://docs.kde.org/stable5/en/kde-workspace/knetattach//knetattach.

Removing `/knetattach` from `help:/knetattach` makes final URL as:
https://docs.kde.org/stable5/en/kde-workspace/knetattach// (Notice the
additional `/` at the end coming from `help:/`). This works for both browser
URL as well as khelpcenter.

M  +1    -1    knetattach/knetattach.cpp

https://invent.kde.org/plasma/plasma-desktop/commit/247d9d732d522548bd8c07a3096669125a28e60d

-- 
You are receiving this mail because:
You are the assignee for the bug.