[clazy] [Bug 408380] detect useless overrides
Иван Туманов
bugzilla_noreply at kde.org
Fri Jun 7 12:56:53 BST 2019
https://bugs.kde.org/show_bug.cgi?id=408380
Иван Туманов <tu4manjohn at yandex.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tu4manjohn at yandex.ru
--- Comment #1 from Иван Туманов <tu4manjohn at yandex.ru> ---
(In reply to Milian Wolff from comment #0)
> SUMMARY
> struct foo { virtual void asdf(); }
> struct bar : foo { void asdf() override { foo::asdf(); } }
>
> The override is completely useless, and I find such code far too often -
> could clazy/clang-tidy detect it and remove the useless code?
>
> it may be problematic to detect when
>
> - non-trivial arguments are forwarded (still useless)
> - Q_UNUSED or similar
> - instead of calling the parent implementation, the parent implementation
> code is duplicated:
>
> struct foo { virtual void asdf() { printf("hello"); }
> struct bar : foo { void asdf() override { printf("hello"); } }
>
> OBSERVED RESULT
> not detected
>
> EXPECTED RESULT
> useless overrides are marked and offered for automatic removal
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the Unassigned-bugs
mailing list