[drkonqi] [Bug 383863] Absence of DrKonqi icon in a tray after same crash reappeared

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=383863

--- Comment #6 from Harald Sitter <sitter at kde.org> ---
Git commit 3eeb0ce5bc1ee61dc9c9ff4376cad5302db4e2de by Harald Sitter.
Committed on 23/07/2019 at 13:42.
Pushed by sitter into branch 'Plasma/5.16'.

guard against plasmashell being properly dead and not showing the SNI

Summary:
when plasmashell is particularly dead and not even able to restart, the SNI
host may still be around when we check for it in the main.cpp as its
disappearance from dbus is tied to sockets closing and dbus' event loop
reacting to that. so there is a race potential that can cause the SNI
to not actually be visible on account of the SNI host (plasmashell)
being dead even though we expected SNI support to be available.

guard against this scenario by starting an automatic activation timer
when the notification service disappears. should it not reappear within
10 second we consider it dead and show the dialog automatically as the
user won't be seeing the SNI anymore

Possibly fixing

Test Plan:
- crash something so the sni appears
- kill plasma
- wait 10s
- dialog appears

- same again
- restart plasma before 10s have passed
- sni appears again in plasmashell

Reviewers: #plasma

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22553

M  +18   -0    src/statusnotifier.cpp

https://commits.kde.org/drkonqi/3eeb0ce5bc1ee61dc9c9ff4376cad5302db4e2de

-- 
You are receiving this mail because:
You are the assignee for the bug.