[drkonqi] [Bug 375462] Login Details

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=375462

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.17.0
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://commits.kde.org/drk
                   |                            |onqi/83c98bd28c4a4fa0a618ea
                   |                            |e31995defd5126e095

--- Comment #2 from Harald Sitter <sitter at kde.org> ---
Git commit 83c98bd28c4a4fa0a618eae31995defd5126e095 by Harald Sitter.
Committed on 03/07/2019 at 13:44.
Pushed by sitter into branch 'master'.

change username labels to e-mail address instead

Summary:
users in bugzilla are always identified by their email address so it makes
no sense to label the input username.

calling it email address is also consistent with the bugzilla webui itself.

that said, we actually spell it inconstantly email or e-mail across
software. the most prominent cases in kdepim though spell it
"E-mail Address" for input labels. so, going with that

for ease of reading I'm leaving the code variables and the likes to say
username as this more obviously ties to the related password variables.
FIXED-IN: 5.17.0

Test Plan: login page now has an email address label

Reviewers: #plasma, ngraham, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D22212

M  +1    -1    src/aboutbugreportingdialog.cpp
M  +4    -4    src/bugzillaintegration/reportassistantpages_bugzilla.cpp
M  +1    -1    src/bugzillaintegration/ui/assistantpage_bugzilla_login.ui

https://commits.kde.org/drkonqi/83c98bd28c4a4fa0a618eae31995defd5126e095

-- 
You are receiving this mail because:
You are the assignee for the bug.