[clazy] [Bug 391812] New: False positive for check "function-args-by-value"

[Roman]

https://bugs.kde.org/show_bug.cgi?id=391812

            Bug ID: 391812
           Summary: False positive for check "function-args-by-value"
           Product: clazy
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: unassigned-bugs at kde.org
          Reporter: dismine at gmail.com
                CC: smartins at kde.org
  Target Milestone: ---

I am not sure if this is worth to fix but anyway.

For virtual method

virtual void updateState(const QPaintEngineState &state) = 0;

i declare implementation like this

virtual void updateState(const QPaintEngineState &state) Q_DECL_OVERRIDE;

Because class QPaintEngineState is trivial i get warning
"function-args-by-value". And i cannot fix declaration because this breaks
overload. And also i cannot fix class QPaintEngine because it is part of Qt
headers.

Of course i can suppress the warning, but still, if clazy would be little bit
smarter and ignore such cases from system headers. Don't know how good the idea
is, maybe not really. But it is natural to want reduce any noise if nothing you
can do about it.

-- 
You are receiving this mail because:
You are the assignee for the bug.