[systemsettings] [Bug 361960] kfontinst freezes adding fonts to system

[Mathias Tillman]

https://bugs.kde.org/show_bug.cgi?id=361960

Mathias Tillman <master.homer at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
                   |sma-desktop/60c895758f20bd2 |sma-desktop/690570a4cefd786
                   |cb17ab12e57cf34cc37197098   |db5113ca237e9bdb48cd50812

--- Comment #13 from Mathias Tillman <master.homer at gmail.com> ---
Git commit 690570a4cefd786db5113ca237e9bdb48cd50812 by Mathias Tillman.
Committed on 02/08/2018 at 07:33.
Pushed by mathiastillman into branch 'Plasma/5.12'.

fontinst quits after KJob is done

Summary:
As the summary says, when installing/removing multiple fonts to system the
expected behaviour would be for fontinst to keep running after the first font
has been installed or removed, instead it quits which causes a bunch of issues.
fontinst uses KJob to authorize and internally KJob uses a QEventLoopLocker
which causes the main event loop to quit when it's done.
I'm not entirely sure why the event loop locker is enabled by default for KJob,
but the patch I have attached works around this by completely disabling that
functionality for fontinst. There's a timer that runs in the background which
checks for any connected clients, so it will quit after a little while
regardless.
Related: bug 379524, bug 379324, bug 349673, bug 392267

Test Plan: Make sure fonts are still installed and removed properly.

Reviewers: #plasma, dfaure, aacid, gateau

Reviewed By: dfaure

Subscribers: wbauer, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14493

(cherry picked from commit 60c895758f20bd2cb17ab12e57cf34cc37197098)

M  +4    -0    kcms/kfontinst/dbus/Main.cpp

https://commits.kde.org/plasma-desktop/690570a4cefd786db5113ca237e9bdb48cd50812

-- 
You are receiving this mail because:
You are the assignee for the bug.