[systemsettings] [Bug 373628] systemsettings5 crashes when closing or going back

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=373628

--- Comment #61 from David Edmundson <kde at davidedmundson.co.uk> ---
Git commit 29179f115c81ff7128bb5430cb27ef7b65f46b33 by David Edmundson.
Committed on 10/02/2017 at 09:52.
Pushed by davidedmundson into branch 'Plasma/5.9'.

Avoid a crash on Kwin decoration KCM teardown

Summary:
As described in https://bugreports.qt.io/browse/QTBUG-57714  exposing a
QWidget as a context item to QtQuick can crash. Especially as the
engine's context property gets deleted whilst deleting the parent item.

This patch reworks the code so that the models are exposed to QML
directly rather than going through a QWidget.

Test Plan:
Pressing back whilst in the decoration KCM used to crash every time, now it
doesn't.
I still have the buttons.

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: graesslin, cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4533

M  +4    -16   kcmkwin/kwindecoration/kcm.cpp
M  +0    -7    kcmkwin/kwindecoration/kcm.h
M  +3    -3    kcmkwin/kwindecoration/qml/Buttons.qml

https://commits.kde.org/kwin/29179f115c81ff7128bb5430cb27ef7b65f46b33

-- 
You are receiving this mail because:
You are the assignee for the bug.