[systemsettings] [Bug 358254] Setting the toolbar font does nothing

[Henrik (rkflx)]

https://bugs.kde.org/show_bug.cgi?id=358254

Henrik (rkflx) <rkflx at lab12.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1
                 CC|                            |rkflx at lab12.net

--- Comment #4 from Henrik (rkflx) <rkflx at lab12.net> ---
Allan: I'm working on a similar fix in https://phabricator.kde.org/D6697 (while
I included the bug number, somehow I missed your comment until now as it only
appeared shortly before I submitted my review – sorry for that).

However, it seems I cannot get your fix to Qt working locally. I tried Plasma
(Breeze), IceWM (Fusion) and XFCE (Adwaita), all with Qt 5.9.1 on Tumbleweed
which should include your patch according to gerrit. For testing I created a
MainWindow with a toolbar in Qt Designer. Only with Plasma the MainWindow
picked up KDE's settings: Menubar as specified in kdeglobals, but Toolbar got
general font.

I also tested with Qt 5.6.2, which should not include your patch. We get the
same behaviour as above (only Plasma was tested). This means your patch seems
to change nothing for me. Apparently KDE's settings are picked up only in
Plasma, and then the Plasma QPA takes over which is not based on the unix
platformtheme. Could you share how to reproduce your fix properly? (I might
have missed something). Let me know if we should continue this discussion in
gerrit.

Even though I might commit my patch to Plasma (which works on both 5.6.2 and
5.9.1, so not dependant on your Qt patch) shortly, I'd be interested to
understand your Qt patch properly, as I'll maybe look into the "Toolbar vs
Toolbutton" issue in the next weeks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.