[kde] [Bug 362709] New: kio_sftp.cpp:1239]: (style) Suspicious condition

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362709

            Bug ID: 362709
           Summary: kio_sftp.cpp:1239]: (style) Suspicious condition
           Product: kde
           Version: Git
          Platform: RedHat RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: unassigned-bugs at kde.org
          Reporter: dcb314 at hotmail.com

../../../kioslave/sftp/kio_sftp.cpp:1239]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.

Source code is

    } else if ((errorCode = writeToFile(fd, filedata.constData(),
filedata.size()) != 0)) {

Suggest new code

    } else if ((errorCode = writeToFile(fd, filedata.constData(),
filedata.size())) != 0) {


Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.