[kde] [Bug 366135] audex-0.79: read uninit data ?

[Leslie Zhai via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366135

Leslie Zhai <xiangzhai83 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Leslie Zhai <xiangzhai83 at gmail.com> ---
Hi dcb314,

> QString::toInt() only writes to the variable pointed to, so the code for the first issue is fine.

Please pay more attention to int QString::toInt(bool *ok, int base) const
If a conversion error occurs, *ok is set to false; otherwise *ok is set to
true.
http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qstring.cpp#n6418

Much deeper please see
http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qlocale.cpp#n3277

I know references are syntactic sugar, so code is easier to read and write, and
you can Google with C++ reference vs pointer ;-)

cover was set by setCover
https://github.com/KDE/audex/commit/bd2d7578aa9ee9cd38cb4a55df256200dbe71690

-- 
You are receiving this mail because:
You are the assignee for the bug.