[clazy] [Bug 355593] New: Do not fix connects to static member functions with -fix-old-style-connect

[Tobias Hunger via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355593

            Bug ID: 355593
           Summary: Do not fix connects to static member functions with
                    -fix-old-style-connect
           Product: clazy
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: unassigned-bugs at kde.org
          Reporter: tobias.hunger at gmail.com

Please do not fix old style connects to static member functions. The connect
will actually compile, but the disconnect won't, so it is IMHO better to not
touch these.

E.g.: The following connect/disconnect should be left alone:

#include <QObject>

class TestClass : public QObject
{
public slots:
    TestClass(QObject *parent = nullptr) : QObject(parent) { }

     static void test(QObject *obj) { Q_UNUSED(obj); }
};

int main(int argc, char** argv) {
    auto test = new TestClass;
    connect(test, SIGNAL(destroyed(QObject*)), test, SLOT(test(QObject*)));
    disconnect(test, SIGNAL(destroyed(QObject*)), test, SLOT(test(QObject*)));
}

-- 
You are receiving this mail because:
You are the assignee for the bug.