[Bug 54300] new domain-specific cookie policy: treat as session cookie

[Dawit Alemayehu]

https://bugs.kde.org/show_bug.cgi?id=54300


Dawit Alemayehu <adawit at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adawit at kde.org




--- Comment #18 from Dawit Alemayehu <adawit kde org>  2011-05-04 04:31:22 ---
Gregorio,

First thanks for providing a patch. It is rare that people provide their own
patch for feature they want to have.;) Second, I had plans to commit a modified
version of your patch to KDE 4.6 (see the feature plans page for KDE 4.6), but
I did not have the time to do it. Unfortunately I doubt I will have the time to
do it for KDE 4.7 either since there is way too much on my plate. However, I
will try my best to get it in for KDE 4.8.

In the mean time, there is one thing I do not like with your patch:

You removed the ability to automatically accept session cookies. That is wrong.
For example, I should be able to choose "Ask for confirmation" and still have
the ability to automatically accept "session cookies". Changing the check box
that treats all cookies as session cookies to a selectable option that does the
same on per cookie basis should not deprive the other use cases of this
functionality. If you believe otherwise, please explain why that should not be
the case.

I guess you removed it because it conflicted with the new option when you
should have simply ignored it when the new option is selected. You can even
disable the checkbox associated with it when the user selects the new option in
the config dialog box.

The other issue is the missing test cases. All those unit tests in
kdelibs/kioslave/http/kcookiejar/tests have to be modified to reflect these
changes. Anyhow, this should not be that much of a big deal to go through. The
above issue however is important.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.