[Bug 253111] New: Kmix define OSS4 if only OSS3 is present

[Lóránt Farkas]

https://bugs.kde.org/show_bug.cgi?id=253111

           Summary: Kmix define OSS4 if only OSS3 is present
           Product: kde
           Version: 4.5
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: crash
          Priority: NOR
         Component: general
        AssignedTo: unassigned-bugs at kde.org
        ReportedBy: farkaslory at gmail.com


Version:           4.5 (using KDE 4.5.1) 
OS:                Linux


kmix didn't compiled on my system got error:

In file included from
/var/tmp/portage/kde-base/kmix-4.5.1/work/kmix-4.5.1/kmix/kmix-platforms.cpp:107,
                 from
/var/tmp/portage/kde-base/kmix-4.5.1/work/kmix-4.5.1/kmix/mixer.cpp:32:
/var/tmp/portage/kde-base/kmix-4.5.1/work/kmix-4.5.1/kmix/mixer_oss4.cpp:68:
warning: unused parameter ‘id’
/var/tmp/portage/kde-base/kmix-4.5.1/work/kmix-4.5.1/kmix/mixer_oss4.cpp:68:
warning: unused parameter ‘on’
/var/tmp/portage/kde-base/kmix-4.5.1/work/kmix-4.5.1/kmix/mixer_oss4.cpp: In
member function ‘MixDevice::ChannelType Mixer_OSS4::classifyAndRename(QString&,
int)’:
/var/tmp/portage/kde-base/kmix-4.5.1/work/kmix-4.5.1/kmix/mixer_oss4.cpp:80:
error: ‘MIXF_MONVOL’ was not declared in this scope

However I didn't installed OSS4. I think the problem is in kmix-platforms.cpp
see below.

Reproducible: Always

Steps to Reproduce:
Try to compile kmix with 

define SOUND_VERSION = 0x030000

in e.g. soundcard.h on linux.

Actual Results:  
kmix didn't compiled.

Expected Results:  
kmix should cmpile cleanly.

The relevant code segment is in kmix/kmix-platforms.cpp:

// OSS 3 / 4

...

#if !defined(__FreeBSD__) && SOUND_VERSION >= 0x040000
#define OSS4_MIXER
#endif

which is true if SOUND_VERSION is defined and not 0. Thus the compilation fail
if no OSS4 is installed.

This should be correct to 

#if !defined(__FreeBSD__) && (SOUND_VERSION >= 0x040000)
#define OSS4_MIXER
#endif

and all ok.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.