[Bug 172281] Changing "event source" in System Notifications causes "unsaved changes"

[Alan Jenkins]

http://bugs.kde.org/show_bug.cgi?id=172281





--- Comment #1 from Alan Jenkins <alan-jenkins tuffmail co uk>  2008-10-07 20:15:53 ---
Created an attachment (id=27741)
 --> (http://bugs.kde.org/attachment.cgi?id=27741)
Proposed fix

When "Event Source" is changed, the module saves the changes and emits
changed(true), which means "I now have unsaved changes".  What it should do is
emit changed(false), which means "I have just saved all changes".

diff --git a/kcontrol/knotify/knotify.cpp b/kcontrol/knotify/knotify.cpp
index 1f6fa52..80fd62d 100644
--- a/kcontrol/knotify/knotify.cpp
+++ b/kcontrol/knotify/knotify.cpp
@@ -132,7 +132,7 @@ void KCMKNotify::slotAppActivated( int index )
         text=m_appNames[index];
     m_notifyWidget->save();
     m_notifyWidget->setApplication( text );
-    emit changed(true);
+    emit changed(false);
 }

 void KCMKNotify::slotPlayerSettings()


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.