[umbrello] [Bug 81364] Import Rose model files

Oliver Kellogg bugzilla_noreply at kde.org
Wed Mar 30 06:14:29 BST 2022


https://bugs.kde.org/show_bug.cgi?id=81364

--- Comment #39 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit d6f1ebc2fbc6ae34f999a6ea228097555a0ade68 by Oliver Kellogg.
Committed on 30/03/2022 at 05:14.
Pushed by okellogg into branch 'master'.

umbrello/petaltree2uml.cpp improvements on converting diagram elements:

- Move viewTagToWidget from function umbrellify to global level and
  reset it to empty on beginning parse of diagram.
- In function handleAssocView :
  - Do not fail if attribute "roleview_list" is not found.  Reason:
    InheritView, RealizeView, and UsesView do not have this attribute.
  - If "roleview_list" is not present then retrieve `supplier` and
    `client` using attr->findAttribute() for "supplier" and "client",
    respectively.
  - Move locals supW and cliW up to wider scope in order to attempt
    their retrieval from viewTagToWidget[supplier] and
    viewTagToWidget[client], respectively. Execute the code involving
    view->umlScene()->widgetOnDiagram() only if client and/or supplier
    is not a key in viewTagToWidget.
- In function umbrellify case (dt != Uml::DiagramType::Undefined) :
  - Clear viewTagToWidget.
  - In for-loop over atts, on handling CategoryView/ClassView etc
    retrieve attribute "icon" from attr. If it is "Interface" then
    - set local pointer cw to dynamic_cast<ClassifierWidget*>(w);
    - if cw is non null then set visual property `DrawAsCircle` on cw.

M  +79   -53   umbrello/petaltree2uml.cpp

https://invent.kde.org/sdk/umbrello/commit/d6f1ebc2fbc6ae34f999a6ea228097555a0ade68

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list