[umbrello] [Bug 451735] [activity diagram] Pressing OK in General Properties of Initial or End activity changes its type/shape

[Oliver Kellogg]

https://bugs.kde.org/show_bug.cgi?id=451735

Oliver Kellogg <okellogg at users.sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.33.80 (KDE releases
                   |                            |22.03.80)
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |umbrello/commit/5a9b74243d2
                   |                            |e59ab5b8ebf4ed12457cd282a3d
                   |                            |79

--- Comment #1 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit 5a9b74243d2e59ab5b8ebf4ed12457cd282a3d79 by Oliver Kellogg.
Committed on 20/03/2022 at 19:00.
Pushed by okellogg into branch 'release/22.04'.

Fix "Pressing OK in General Properties of Initial or End activity changes its
type/shape"

umbrello/dialogs/activitydialog.cpp
- In function applyPage case (item == pageItemGeneral),
  - add local bool setType initialized to false;
  - if m_GenPageWidgets.NormalRB->isChecked() is true then set newType
    to ActivityWidget::Normal and set setType true;
  - in the then-parts of the other isChecked() tests, in addition
    to setting newType set setType true;
  - after the if-else chain call m_pActivityWidget->setActivityType for
    newType only if setType is true.
FIXED-IN: 2.33.80 (KDE releases 22.03.80)

M  +15   -7    umbrello/dialogs/activitydialog.cpp

https://invent.kde.org/sdk/umbrello/commit/5a9b74243d2e59ab5b8ebf4ed12457cd282a3d79

-- 
You are receiving this mail because:
You are the assignee for the bug.