[umbrello] [Bug 397909] Develop Vala importer

Oliver Kellogg bugzilla_noreply at kde.org
Sat Feb 19 21:28:31 GMT 2022


https://bugs.kde.org/show_bug.cgi?id=397909

--- Comment #12 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit 7dbb75549a72334cf426969295364aee5f9ff0c7 by Oliver Kellogg.
Committed on 16/02/2022 at 03:44.
Pushed by okellogg into branch 'master'.

New class CsValaImportBase is quasi abstract base for C# and Vala import

- Move content of umbrello/codeimport/csharp/csharpimport.{h,cpp} to
  umbrello/codeimport/csvalaimportbase.{h,cpp} and adjust class name to
  CsValaImportBase.
- Move umbrello/codeimport/valaimport.{h,cpp} to new subdirectory vala
  and derive the class from CsValaImportBase.
- Copy content of umbrello/codeimport/vala/valaimport.{h,cpp} to
  umbrello/codeimport/csharp/csharpimport.{h,cpp}, restore class name
  CSharpImport, and restore correct body of function fileExtension().
- In umbrello/codeimport/CMakeLists.txt add file csvalaimportbase.cpp
  and adjust to new subdirectory "vala" with file valaimport.cpp.

M  +3    -1    umbrello/codeimport/CMakeLists.txt
M  +5    -760  umbrello/codeimport/csharp/csharpimport.cpp
M  +5    -67   umbrello/codeimport/csharp/csharpimport.h
C  +42   -42   umbrello/codeimport/csvalaimportbase.cpp [from:
umbrello/codeimport/csharp/csharpimport.cpp - 090% similarity]
C  +6    -7    umbrello/codeimport/csvalaimportbase.h [from:
umbrello/codeimport/csharp/csharpimport.h - 088% similarity]
A  +31   -0    umbrello/codeimport/vala/valaimport.cpp     [License:
GPL(v2.0+)]
A  +25   -0    umbrello/codeimport/vala/valaimport.h     [License: GPL(v2.0+)]
D  +0    -27   umbrello/codeimport/valaimport.cpp
D  +0    -25   umbrello/codeimport/valaimport.h

https://invent.kde.org/sdk/umbrello/commit/7dbb75549a72334cf426969295364aee5f9ff0c7

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list