[umbrello] [Bug 449662] request: restore undo/redo buttons missing in KF5 build

Oliver Kellogg bugzilla_noreply at kde.org
Sat Feb 19 08:20:48 GMT 2022


https://bugs.kde.org/show_bug.cgi?id=449662

Oliver Kellogg <okellogg at users.sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |2.33.80 (KDE releases
                   |                            |22.03.80)
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |umbrello/commit/23349c46cc5
                   |                            |f9c3b0e8ef090e518ba50dcda82
                   |                            |6d

--- Comment #11 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit 23349c46cc5f9c3b0e8ef090e518ba50dcda826d by Oliver Kellogg.
Committed on 19/02/2022 at 08:20.
Pushed by okellogg into branch 'master'.

Fix "request: restore undo/redo buttons missing in KF5 build"

umbrello/uml.cpp
- In constructor, for symmetry with other members pre-initialize member
  m_undoEnabled.
- In function readOptions :
  - Factor toolBar(QLatin1String("mainToolBar")) into local mainToolBar
    pointer to KToolBar.
  - If QT_VERSION major is 5 or larger then
    - add seperator in mainToolBar;
    - set "edit-undo" / "edit-redo" in local QStrings undoIconName and
      redoIconName;
    - set local QIcons undoIcon and redoIcon using QIcon::fromTheme()
      with undoIconName and redoIconName;
    - set undoIcon in editUndo and set redoIcon in editRedo;
    - call mainToolBar->addAction() with argument editUndo and editRedo.
FIXED-IN:2.33.80 (KDE releases 22.03.80)

M  +23   -2    umbrello/uml.cpp

https://invent.kde.org/sdk/umbrello/commit/23349c46cc5f9c3b0e8ef090e518ba50dcda826d

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list