[umbrello] [Bug 450196] [C++ import] Type std::string is created multiple times

Oliver Kellogg bugzilla_noreply at kde.org
Mon Feb 14 08:32:11 GMT 2022


https://bugs.kde.org/show_bug.cgi?id=450196

Oliver Kellogg <okellogg at users.sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.33.80 (KDE releases
                   |                            |22.03.80)
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |umbrello/commit/7760dfff825
                   |                            |a2a4643f6c7ea2f9d0f60e83969
                   |                            |bf

--- Comment #2 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit 7760dfff825a2a4643f6c7ea2f9d0f60e83969bf by Oliver Kellogg.
Committed on 14/02/2022 at 08:30.
Pushed by okellogg into branch 'master'.

Fix "[C++ import] Type std::string is created multiple times"

umbrello/codeimport/import_utils.{h,cpp}
- New function checkStdString takes a writable reference to QString
  as argument. If the variable passed in contains "std::string" it will
  be changed to "string".

umbrello/codeimport/import_utils.cpp
- In function createUMLObject :
  - Before attempting to find the UMLObject by name call
    checkStdString(name).
  - In the code handling nullptr return from first search,
    - remove `const' on definition of local isConst;
    - search `name' for "const" delimited at start and end by word
      boundary and remove the possible matched item;
    - apply checkStdString(typeName) before attempting to find the
      UMLObject by typeName;
    - before calling Object_Factory::createUMLObject fix condition for
      changing `t' from ot_UMLObject to ot_Class.
  - As a peripheral change, near start of function,
    - simplify handling of leading "::" in name;
    - handle Ada specific name prefix "Standard".
- At function addMethodParameter remove obsolete documentation.
FIXED-IN:2.33.80 (KDE releases 22.03.80)

M  +39   -14   umbrello/codeimport/import_utils.cpp
M  +2    -0    umbrello/codeimport/import_utils.h

https://invent.kde.org/sdk/umbrello/commit/7760dfff825a2a4643f6c7ea2f9d0f60e83969bf

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list