[umbrello] [Bug 432688] Python code generator does not add typehints

Oliver Kellogg bugzilla_noreply at kde.org
Thu Dec 23 00:56:30 GMT 2021


https://bugs.kde.org/show_bug.cgi?id=432688

Oliver Kellogg <okellogg at users.sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |umbrello/commit/5b860d44d97
                   |                            |ea011a943bfed80e58f9c62dbd3
                   |                            |54
         Resolution|---                         |FIXED

--- Comment #2 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit 5b860d44d97ea011a943bfed80e58f9c62dbd354 by Oliver Kellogg.
Committed on 23/12/2021 at 00:55.
Pushed by okellogg into branch 'master'.

https://invent.kde.org/sdk/umbrello/-/merge_requests/22

Apply outstanding changes from fix_argument_type_python3 branch of
                    https://invent.kde.org/patrickpereira/umbrello :

umbrello/codegenerators/python/pythonwriter.{h,cpp}
- Add functions fixTypeName, findIncludeFromType.

umbrello/codegenerators/python/pythonwriter.cpp
- In function writeClass,
  - in loop over includes use new function findIncludeFromType to avoid
    including Python predefined classes;
  - on printing superclasses omit inheritance from `object' (not needed
    in python3).
- In function writeOperations loop over opList nested loop over atl use
  new function fixTypeName on at->getTypeName() to make the types
  compatible with Python.

M  +86   -11   umbrello/codegenerators/python/pythonwriter.cpp
M  +3    -0    umbrello/codegenerators/python/pythonwriter.h

https://invent.kde.org/sdk/umbrello/commit/5b860d44d97ea011a943bfed80e58f9c62dbd354

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list