[umbrello] [Bug 347498] valgrind reports memory leaks

[Oliver Kellogg]

https://bugs.kde.org/show_bug.cgi?id=347498

--- Comment #9 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit 41b8e258d9ca1bcee82a687ea0d25a5cb56c10c9 by Oliver Kellogg.
Committed on 03/10/2020 at 22:33.
Pushed by okellogg into branch 'master'.

https://bugs.kde.org/show_bug.cgi?id=347498#c8
> I experienced the following crash on exiting Umbrello:
> Application: Umbrello...  (umbrello5), signal: Segmentation fault
> [...]
> AFAICT the critical place is umlobject.cpp ... setUMLStereotype,
>    emitModified();
> We should not emit the signal during destruction.

umbrello/uml.{h,cpp}
- Add public static function shuttingDown() returning bool.
- Add private static variable s_shuttingDown with documentation on why
  this variable is static.
- In UMLApp destructor set s_shuttingDown to true.

- In function setUMLStereotype(UMLStereotype) conditionalize call to
  emitModified() on UMLApp::shuttingDown() returning false.

M  +17   -0    umbrello/uml.cpp
M  +3    -0    umbrello/uml.h
M  +2    -1    umbrello/uml1model/umlobject.cpp

https://invent.kde.org/sdk/umbrello/commit/41b8e258d9ca1bcee82a687ea0d25a5cb56c10c9

-- 
You are receiving this mail because:
You are the assignee for the bug.