[umbrello] [Bug 429794] Callback message in sequence diagram cannot be resized

Oliver Kellogg bugzilla_noreply at kde.org
Sun Nov 29 22:40:59 GMT 2020


https://bugs.kde.org/show_bug.cgi?id=429794

Oliver Kellogg <okellogg at users.sourceforge.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |umbrello/commit/eae999b7903
                   |                            |c30a7570ba7f5e907801cd399cb
                   |                            |c4
         Resolution|---                         |FIXED
             Status|REPORTED                    |RESOLVED

--- Comment #1 from Oliver Kellogg <okellogg at users.sourceforge.net> ---
Git commit eae999b7903c30a7570ba7f5e907801cd399cbc4 by Oliver Kellogg.
Committed on 29/11/2020 at 22:40.
Pushed by okellogg into branch 'master'.

Fix for 'Callback message in sequence diagram cannot be resized'

umbrello/umlwidgets/messagewidget.{h,cpp}
- Reimplement UMLWidget::isInResizeArea instead of resizeCursor.
  Reason: In case of a message widget running from right to left, the
  resize area is at the left bottom corner because the message's
  execution specification is also at the left.  Furthermore, the right
  side may be covered up by another message's execution specification.

umbrello/umlwidgets/umlwidget.cpp
- In function mousePressEvent extend debug message to show pos() and
  event->scenePos().
- In function paint(QPainter*,const QStyleOptionGraphicsItem*, QWidget*)
  case (option->state & QStyle::State_Selected)
    case (m_resizable && w >= s+8 && h >= s+8),
  - int horSide initialized to `w' replaces variable `right';
  - if baseType() is wt_Message and the message's role A ObjectWidget is
    to the right of the role B ObjectWidget then set horSide to a small
    value in order to place the resize anchor at the role B object;
  - in calls to painter->drawLine() use horSide in lieu of `right'.

M  +45   -8    umbrello/umlwidgets/messagewidget.cpp
M  +4    -4    umbrello/umlwidgets/messagewidget.h
M  +26   -5    umbrello/umlwidgets/umlwidget.cpp

https://invent.kde.org/sdk/umbrello/commit/eae999b7903c30a7570ba7f5e907801cd399cbc4

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the umbrello-devel mailing list